Unity Editor Extension location detection code is faulty
I tried moving the Unity Editor Extensions to a folder named 3rdPartyAssets to fit with our project structure (which is possible according to https://github.com/PlayFab/UnityEditorExtensions), which led to an exception:
NullReferenceException at PlayFabEditorExtensions/Editor/PlayFabEditor.cs:151
The problem appears to be that PlayFabEditorHelper.GetUiStyle() has
eachPath.Substring(eachPath.LastIndexOf("Assets"));
which incorrectly matched our 3rdPartyAssets path.
I edited that, and installed & relocated the SDK, but then the code to detect the relocation of EditorExtensions failed, because a copy of the unity package was stored in the default location, and PlayFabEditorHelper interprets the presence of files in the default location as evidence that EditorExtensions hasn't been moved.
Finally, the EdExPath in the PlayFabEditorPrefsSO scriptable object contained the absolute path of the folder, which obviously was incorrect on our other users' machines,causing new default files to be generated. I modified this to be a relative path.
The PlayFabEditorExtensions SDK should be imported to Assets Folder by default. It is currently not support to move the PlayFabEditorExtensions Folder under other folders whose name contains string “Assets”. A solution could be to change the Folder name from “3rdPartyAssets” to one that does not contain “Assets”, for example, “3rdPartySDK”.
The remainder of my post still stands.
I tried your suggestion in an empty project. After relocating PlayFabEditorExtensions to a folder called '3rdParty', I installed the SDK, and a folder 'PlayFabEditorExtensions' is still created in the root of Assets.
The PlayFabEditorExtensions folder generated in the root of Assets is not important and can be removed, it will not affect the use of PlayFab SDK. If there is any other concerns, please let me know.
