Idea

Dylan Hunt avatar image
Dylan Hunt suggested

Rename PlayFab.ClientModels.FriendInfo

PlayFab.ClientModels.FriendInfo is named as the same base as Photon's "FriendInfo". This is super confusing sometimes and it also means we can't inherit via a custom class with both unless we rename one of them (usually not recommended).

Perhaps FriendInfo >> PFFriendInfo ? Anything would be better~

apis
10 |1200

Up to 2 attachments (including images) can be used with a maximum of 512.0 KiB each and 1.0 MiB total.

2 Comments

·
Dylan Hunt avatar image
Dylan Hunt commented

Err ignore my comment about inheritance -- I just typo'd. The main point is that it's confusing ;D

10 |1200

Up to 2 attachments (including images) can be used with a maximum of 512.0 KiB each and 1.0 MiB total.

Joshua Strunk avatar image
Joshua Strunk commented

This would be a breaking change to prevent a cosmetic naming conflict with a 3rd party service. This is the exact use case namespaces exist for.

Depending on your environment, you should be able to solve this any number of ways without a breaking API change on PlayFab's end. Some ways in C# would be.

  • Don't use "using PlayFab.ClientModels;" statements in the files these conflicts exist, instead write out the full "PlayFab.ClientModels.FriendInfo" type every time.
  • Don't use "using PlayFab.ClientModels;" statements in the files these conflicts exist, instead write out type alias for only the types you are using. ex "using PFFriendInfo = PlayFab.ClientModels.FriendInfo;"
10 |1200

Up to 2 attachments (including images) can be used with a maximum of 512.0 KiB each and 1.0 MiB total.

Write a Comment

Up to 2 attachments (including images) can be used with a maximum of 512.0 KiB each and 1.0 MiB total.

Your Opinion Counts

Share your great idea, or help out by voting for other people's ideas.